Update Docs to use new Notes form and use yarn for addon install #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated instructions to use yarn and new form instead of old component wrapper form
paul42
requested review from
alexandrebodin,
Hypnosphi,
ndelangen and
shilman
as code owners
Hypnosphi
added
documentation
patch:yes
Codecov Report
@@ Coverage Diff @@
## master #3309 +/- ##
=======================================
Coverage 35.63% 35.63%
=======================================
Files 472 472
Lines 10121 10121
Branches 947 964 +17
=======================================
Hits 3607 3607
+ Misses 5949 5889 -60
- Partials 565 625 +60
Continue to review full report at Codecov.
|
Hypnosphi
approved these changes
Mar 29, 2018
|
thanks @Hypnosphi I appreciate the help! |
Hypnosphi
added a commit
that referenced
this pull request
Mar 30, 2018
Update Docs to use new Notes form and use yarn for addon install
Hypnosphi
added
the
patch:done
This was referenced Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3305
What I did
Updated documents
How to test
View help documents and verify they look acceptable
Is this testable with Jest or Chromatic screenshots?
no?
Does this need a new example in the kitchen sink apps?
no
Does this need an update to the documentation?
N/A, this is a documentation update
If your answer is yes to any of these, please make sure to include it in your PR.